Skip to content

Supply default function #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 20, 2025

Conversation

xpirad
Copy link
Collaborator

@xpirad xpirad commented Feb 18, 2025

No description provided.

Copy link
Contributor

@HerrCai0907 HerrCai0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./assembly is library for framework user. Don't put any test logic here.

please add unit test for new code

@xpirad xpirad requested a review from a team as a code owner February 19, 2025 02:29
HerrCai0907
HerrCai0907 previously approved these changes Feb 20, 2025
Copy link
Contributor

@HerrCai0907 HerrCai0907 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@HerrCai0907 HerrCai0907 merged commit e05ac6d into wasm-ecosystem:main Feb 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants